fix: add calculation to display correct pull request velocity #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jpmcb
requested changes
Oct 2, 2023
There was a problem hiding this comment.
This is great!! 👏🏼 I think this needs just abit more to be in line with what we surface in the insights app. For example, on Nick's profile:
and in the pizza show:
So, the 80 in this case should really be "80% merged" which represents the percent of merged prs within the given time frame. And we should also surface 1d which represents that averge velocity of prs to merge. You should be able to pull off the
m.userInfo.RecentPullRequestVelocityCount
which gets surfaced off the API.
So something like this (ignore the poorly formatted table 🙈 )?
│ nickytonline │
│ │
│ 🔥 PR Velocity (30d): 1d - 80% merged 📄 Issues: 50 │
│ │
│ │
│ 🚀 PR Count (30d): 17 🔨 Maintainer: true │
│ │
k1nho
force-pushed
the
fix/calculate-pr-velocity-count
branch
from
c23b330 to
5a17c5d
Compare
|
Thanks for the feedback! I understand better this metric. I always though it referred to the percentage, but reading through this issue was helpful refactor: update pr velocity indicator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a calculation to get the correct pull request velocity percentage to display. It calculates the percentage with the same formula implemented by the
getPercent(total, count)method. This approach is used indev-cardcomponent viagetPercent(prTotal, mergedPrs)to render the percentage in theVelocityPill.https://github.com/open-sauced/app/blob/5b15a49d6dfbd371799d7dbf81cd5cbfef5e1d60/lib/utils/get-percent.ts#L1
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #45
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?